Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Current Situational Data #81

Open
bfox6 opened this issue Mar 30, 2018 · 4 comments
Open

Add Current Situational Data #81

bfox6 opened this issue Mar 30, 2018 · 4 comments

Comments

@bfox6
Copy link

bfox6 commented Mar 30, 2018

Add data such as the current batter and pitcher.

Could possibly be added to the Overview class.

@panzarino
Copy link
Owner

@trevor-viljoen I don't really have time to do this, would you like to take a look at this?

@ajbowler
Copy link
Contributor

ajbowler commented Apr 1, 2018

I believe Trevor is working on this, this was a feature he requested in the scoreboard Slack channel

@trevor-viljoen
Copy link
Contributor

@panzarino I'll try to get to it this week. I spent most of the day trying to refactor stats.py to fix the code climate findings. I think I have a solution, but there are a couple bugs I'm trying to track down with it.

@trevor-viljoen
Copy link
Contributor

trevor-viljoen commented Oct 13, 2018

@ajbowler @panzarino @bfox6 I've got code for this I will be working into a PR. It will get all elements and attributes from the linescore.xml files and make them available as python objects.

This will include the linescore, home_runs, situational_data (see below), winning_pitcher, losing_pitcher, save_pitcher, game_media, and reviews (how many challenges remain).

situational_tags = ['current_batter', 'current_ondeck', 'current_inhole',
                    'due_up_batter', 'due_up_ondeck', 'due_up_inhole', 
                    'current_pitcher', 'opposing_pitcher']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants