Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PANTS_DEBUG mode is not fully faithful to the ./pants implementation. #127

Open
jsirois opened this issue Feb 21, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@jsirois
Copy link
Contributor

jsirois commented Feb 21, 2023

The ./pants implementation has a best-effort attempt to catch cases where you attempt to PANTS_DEBUG and do not turn off pantsd:
https://github.com/pantsbuild/setup/blob/15988fe15cc87031235ecd0e94ebc38df692a910/pants#L498-L501

Either the same best-effort could be made (note that PANTS_PANTSD is not checked nor is the --pantsd=False form, etc) or scie-pants could just force --no-pantsd and maybe emit a warning it is doing so.

@jsirois jsirois added the bug Something isn't working label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant