Show dev / main-branch docs too
#159
Labels
enhancement
New feature or request
Comments
huonw
added a commit
that referenced
this issue
Mar 12, 2024
The goal here is to centralise the logic around versions, creating a list of all the details about each version (e.g. full version number, whether it's a pre-release or unmaintained etc.), that downstream processing can reference directly rather than recompute. This, for instance, eliminates the duplicated logic around which versions are maintained. The goal here is to make changes like #174 (and maybe #159) easier. This PR doesn't/shouldn't change observable behaviour. This also removes the explicit `disableVersioning` flag, since that seems to require changing the contents of the `versions` map. Instead the existing use of `onlyIncludeVersions` seems to do what's intended: make dev builds faster. An `npm start` build takes about 10s both with the old `disableVersioning` setting, or just relying on `onlyIncludeVersions`. This includes some cut-and-paste rearrangement too that makes the diff harder to understand. The commits are individually reviewable.
|
I've adjusted how the versions are configured, in #176, but won't finish this off now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per #155 (comment), docs from the
mainbranch are rendered, but hidden from the version selector dropdown to reduce the noise/keep it streamlined.E.g. https://www.pantsbuild.org/2.20/docs/introduction/welcome-to-pants is available but not visible in the dropdown:
This was discussed briefly on slack and there seemed to be a bit of a consensus that they should be shown. This would help, for instance, reviewing/validating the docs and people doing pre-release testing of new features.
The text was updated successfully, but these errors were encountered: