Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pantsbuild.org/versions has many broken links #147

Open
foobar-coder opened this issue Feb 12, 2024 · 6 comments
Open

pantsbuild.org/versions has many broken links #147

foobar-coder opened this issue Feb 12, 2024 · 6 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@foobar-coder
Copy link

Describe the bug

Many links on the versions page lead to a 404 page

Additional info

Examples:

https://www.pantsbuild.org/2.17.x/docs/introduction/how-does-pants-work

https://www.pantsbuild.org/2.4.x/docs/introduction/how-does-pants-work

@foobar-coder foobar-coder added the bug Something isn't working label Feb 12, 2024
@foobar-coder foobar-coder changed the title https://www.pantsbuild.org/versions has many broken links pantsbuild.org/versions has many broken links Feb 12, 2024
@huonw huonw added the documentation Improvements or additions to documentation label Feb 13, 2024
@huonw
Copy link
Contributor

huonw commented Feb 13, 2024

Oops, sorry for the trouble. Thoughts @thejcannon ?

@thejcannon
Copy link
Member

It's the ".x" in the URL 😢

I don't think this page survived the Great Find-and-Replace

@foobar-coder would you be interested in a little PR?

@thejcannon thejcannon transferred this issue from pantsbuild/pants Feb 13, 2024
@foobar-coder
Copy link
Author

foobar-coder commented Feb 13, 2024

@thejcannon

would you be interested in a little PR?

I could review one for sure.

But I don't know enough about your codebase to fix this problem and open a PR myself

@foobar-coder
Copy link
Author

It's the ".x" in the URL

FWIW, it's not just the x

Example:

https://www.pantsbuild.org/2.6/docs/introduction/how-does-pants-work
https://www.pantsbuild.org/2.6/docs/

@huonw
Copy link
Contributor

huonw commented Feb 14, 2024

Thanks @foobar-coder !

The page in question is https://github.com/pantsbuild/pantsbuild.org/blob/main/src/pages/versions/index.md

Good catch with those extra problems, it looks like there's a two sets of fixes to make:

  • remove the .xs
  • change the starting point links for all versions
versions starting page example
2.10 - 2.19 docs/introduction/welcome-to-pants https://www.pantsbuild.org/2.10/docs/introduction/welcome-to-pants
2.6 - 2.9 docs/learn-about-pants/welcome-to-pants https://www.pantsbuild.org/2.6/docs/learn-about-pants/welcome-to-pants
2.0 - 2.5 docs/introduction/welcome-to-pants https://www.pantsbuild.org/2.0/docs/introduction/welcome-to-pants

@huonw
Copy link
Contributor

huonw commented Feb 14, 2024

Oh, hm, versions 2.10 - 2.19 have a welcome-to-pants page too (e.g. https://www.pantsbuild.org/2.10/docs/introduction/welcome-to-pants), and that's the default one (e.g the "Docs" link in the navbar is to https://www.pantsbuild.org/2.18/docs/introduction/welcome-to-pants), but the versions page links to https://www.pantsbuild.org/2.18/docs/introduction/how-does-pants-work instead. I've adjusted the table to suggest they need to be updated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants