Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic re-indexing on deploy #125

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Automatic re-indexing on deploy #125

wants to merge 3 commits into from

Conversation

thejcannon
Copy link
Member

@thejcannon thejcannon commented Jan 16, 2024

The command is documented here: https://www.algolia.com/doc/rest-api/crawler/#reindex-with-a-crawler

I tested it locally.

Also, using my ID/API key for now.

Fixes #124

@thejcannon thejcannon requested a review from huonw January 16, 2024 21:49
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, just a question or two

curl \
-H "Content-Type: application/json" \
-X POST \
--user ${{ secrets.THEJCANNON_ALGOLIA_CRAWLER_USER_ID }}:${{ secrets.THEJCANNON_ALGOLIA_CRAWLER_API_KEY }} \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, does someone else have access to this account? E.g. something in the 1password vault that supposedly exists / associated with @WorkerPants's email?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I invited Benjy. If you want I can invite you as well.

Inviting worker pants might also work in addition. I'll try it out

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benjy says he didn't see the email 😓

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says invitation was sent. Let's see if Benjy can get logged in as WorkerPants via GitHub SSO and see the app.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK Benjy got logged in, but oddly the crawler(s) seem to be per-user. Will keep banging on it.

.github/workflows/deploy.yml Show resolved Hide resolved
@thejcannon thejcannon requested a review from huonw January 17, 2024 18:22
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

curl \
-H "Content-Type: application/json" \
-X POST \
--user ${{ secrets.THEJCANNON_ALGOLIA_CRAWLER_USER_ID }}:${{ secrets.THEJCANNON_ALGOLIA_CRAWLER_API_KEY }} \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it work?

.github/workflows/deploy.yml Show resolved Hide resolved
@huonw
Copy link
Contributor

huonw commented Feb 4, 2024

What's the status of this?

@thejcannon
Copy link
Member Author

I think I have access to the new account myself, so at some point I can either figure it out or open a support ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kickoff a new crawl in deploy
2 participants