Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Liquid Tags syntax highlighting - lost texmate scopes granularity #178

Open
muchisx opened this issue Nov 7, 2023 · 2 comments
Open
Labels
⚠️ Monitoring 🔖 Need More Information Issues requires more information

Comments

@muchisx
Copy link
Collaborator

muchisx commented Nov 7, 2023

After the new update most tags haven't been able to be associated with their scope identity.

Most of them are being associated with just entity.name.tag.other.liquid when in the past we had granularity (so we can edit how each token looks by color and text style etc..)

for example. the ones under ITERATION used to be entity.name.tag.iteration.liquid

Here's a test

image

{% # ---------------------- VARIABLE %}

{% # assign %}
{% assign variable_name = value %}

{% # capture %}
{% capture variable %}
  value
{% endcapture %}

{% # decrement %}
{% decrement variable_name %}

{% # increment %}
{% increment variable_name %}

{% # ---------------------- CONDITIONAL %}

{% # unless %}
{% unless condition %}
  test
{% endunless %}

{% # case %}
{% case variable %}
  test
  {% when condition %}
  test
  {% else %}
{% endcase %}

{% # if %}
{% if condition %}
  test
  {% elsif condition2 %}
  test  
  {% else %}
  test
{% endif %}

{% # ---------------------- HTML %}

{% # form %}
{% form 'name', product %}
{% endform %}

{% # style %}
{% style %}
  div {
    color: blue;
  }
{% endstyle %}

{% # ---------------------- ITERATION %}

{% # for %}
{% for item in collection %}
  {% break %}
  {% continue %}
  {% else %}
  {% cycle 'odd', 'even' %}
{% endfor %}

{% # tablerow %}
{% tablerow variable in array %}
  expression
{% endtablerow %}

{% # paginate %}
{% paginate array by page_size %}
  {% for item in array %}
    forloop_content
  {% endfor %}
{% endpaginate %}

{% # ---------------------- SYNTAX %}

{% # comment %}
{% comment %}
  content
{% endcomment %}

{% # echo %}
{{ variable }}
{% liquid
  echo variable
%}

{% # liquid %}
{% liquid
  assign message = ''
%}

{% # raw %}
{% raw %}
  {{ 2 | plus: 2 }} equals 4.
{% endraw %}

{% # ---------------------- THEME %}

{% # include %}
{% include 'filename' %}

{% # layout %}
{% layout name %}

{% # render %}
{% render 'filename' %}

{% # section %}
{% section 'filename' %}

{% # sections %}
{% sections 'name' %}

{% # stylesheet %}
{% stylesheet %}
  div {
    color: blue;
  }
{% endstylesheet %}

{% # javascript %}
{% javascript %}
  const test = 'test'  
{% endjavascript %}
@panoply
Copy link
Owner

panoply commented Nov 7, 2023

Interesting, I cannot re-create on my end. No changes applied to scopes, test cases passed. Looking into this now.

@muchisx
Copy link
Collaborator Author

muchisx commented Nov 8, 2023

@panoply I have a vscode profile with only Liquid extension and I can still replicate, would you like me to do a different test?

@panoply panoply added Bug Something isn't working in the vscode extension 🔖 Need More Information Issues requires more information ⚠️ Monitoring and removed Bug Something isn't working in the vscode extension labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ Monitoring 🔖 Need More Information Issues requires more information
Projects
None yet
Development

No branches or pull requests

2 participants