Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] HTML attribute line dedenting after typing "end" #160

Open
davidwarrington opened this issue Jul 20, 2023 · 1 comment
Open

[4.0] HTML attribute line dedenting after typing "end" #160

davidwarrington opened this issue Jul 20, 2023 · 1 comment
Labels
Bug Something isn't working in the vscode extension 🎀 Æsthetic The issue pertains to Æsthetic

Comments

@davidwarrington
Copy link
Collaborator

For reference I'm using the latest VSIX on the next branch

This is a weird one. I was just editing an inline attribute that contains liquid and found that if I type anything after "end" inside the closing Liquid tag it dedents the line.

Screen.Recording.2023-07-20.at.15.19.07.mov

This isn't a critical issue - I can reindent it.
@panoply
Copy link
Owner

panoply commented Jul 21, 2023

Interesting one. Definitely a bug, probably because in Æsthetic it is looking for {% endif %} but it shouldn't, so we have a defect here. I'll upstream to Æsthetic. Might be something I introduced with markup rules lineBreakValue and delimiterTerminus which I still haven't bumped in latest version.

In any sense (as always) this was a good catch.

@panoply panoply added Bug Something isn't working in the vscode extension 🎀 Æsthetic The issue pertains to Æsthetic labels Jul 21, 2023
@panoply panoply changed the title HTML attribute line dedenting after typing "end" [4.0] HTML attribute line dedenting after typing "end" Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working in the vscode extension 🎀 Æsthetic The issue pertains to Æsthetic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panoply @davidwarrington