Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider Response::success parameters #19

Open
panicbit opened this issue Nov 18, 2020 · 0 comments
Open

Reconsider Response::success parameters #19

panicbit opened this issue Nov 18, 2020 · 0 comments
Labels
breaking change

Comments

@panicbit
Copy link
Owner

panicbit commented Nov 18, 2020 •
edited

Response::success should just have the additional body parameter. It should be comparatively rare that one wants to send an empty body and it still can be achieved by simply passing vec![].

#18 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@panicbit