Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run helm upgrade with --dry-run on pull requests #130

Open
TomAugspurger opened this issue Mar 25, 2020 · 1 comment
Open

Run helm upgrade with --dry-run on pull requests #130

TomAugspurger opened this issue Mar 25, 2020 · 1 comment

Comments

@TomAugspurger
Copy link
Member

That would have caught the error causing the failure on staging right now :)
@scottyhq
Copy link
Member

After just battling with circleci for aws authentication (apologies for the many commits to staging), I'd be in favor of refactoring the CI to use just github actions and include a PR workflow that does the dry-run!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TomAugspurger @scottyhq