Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandora FMS API Bugs and Security Issues #204

Open
C4rb0n opened this issue Sep 29, 2022 · 3 comments
Open

Pandora FMS API Bugs and Security Issues #204

C4rb0n opened this issue Sep 29, 2022 · 3 comments

Comments

@C4rb0n
Copy link

C4rb0n commented Sep 29, 2022

Hi,
The following issues are present in the Pandora FMS API:

  1. Under "tree_agents," the following typos exist in "other" field options:
    a) "agent_comentary" should be "agent_commentary"
    b) "agent_last_contant" should be "agent_last_contact"

  2. The second issue is that both agent_last_conta[c]t and agent_last_remote_contact return the exact same date and time values, which end up being the last time the agent was checked. I would expect one of those to return the last time the agent was successfully contacted. As is, none of the API options is able to provide information on the last time an agent contact attempt succeeded. This information is available via web UI but is curiously not exposed via the API.

  3. The API, also under "tree_agent" (and possibly other places), exposes the admin username and password via the fields "module_plugin_user" and "module_plugin_pass"

I am using Pandora FMS 763; however, these are long-standing bugs that have been present at least as far back as version 74x.

Thanks

@C4rb0n C4rb0n changed the title Pandora FMS API Bugs Pandora FMS API Bugs and Security Issues Sep 29, 2022
@slerena
Copy link
Contributor

slerena commented Sep 29, 2022

Thanks for the ticket.

  1. If we change that, we will break running scripts from actual customers. We're working on a new 2.0 API that will fix this typos.
  2. Thats a good idea, what about using a new api call for that? (get OK if is updated, and if not, get OUTDATED?)
  3. Thats a ACL problem, if you have only read access probably don't need access to that data, good idea. We will fix that.

@C4rb0n
Copy link
Author

C4rb0n commented Sep 29, 2022

Regarding item number 2, even if you add a new API to indicate OK/OUTDATED, it is still desirable to retrieve the actual date and time since the agent/module was last reachable. Given that this is already tracked in the database, I imagine it would not be difficult to make the information available via the API.

How about adding two API calls: "agent_last_reachable" and "module_last_reachable" for that purpose?

Thanks

p.s. Out of curiosity, do you have a rough idea when (months or years from now) the 2.0 API will be introduced?

@vgilc
Copy link
Contributor

vgilc commented Sep 30, 2022

In the new API function we will add the last reachable date.

Regarding the new API, we don't have a release date yet. We are also looking forward to release it but we are still working on it.

Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants