BUG: sed errors in make conda-forge and make wheels

[jbrockmendel]

Even after doing brew install gnu-sed. Looks like this is fixed by calling gsed instead

[TomAugspurger]

I don't think gsed is portable. We could try installing sed from conda-forge and using that, since $CONDA_PREFIX/bin should be at the start of the PATH.

…

On Fri, Oct 18, 2019 at 2:50 PM jbrockmendel ***@***.***> wrote: Even after doing brew install gnu-sed. Looks like this is fixed by calling gsed instead — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17?email_source=notifications&email_token=AAKAOIQTP65HGBA3F6XWKD3QPIHOXA5CNFSM4JCLTAFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HS27ISQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKAOIXVO2NPLVVKZ4334YDQPIHOXANCNFSM4JCLTAFA> .

[WillAyd]

did brew not have some kind of thing after installation to link sed to gnu-sed? I vaguely recall some post-install step to make that happen

[TomAugspurger]

I think they print info about using `brew link` to symlink `/usr/local/bin/sed` to `/usr/local/bin/gsed`.

…

On Fri, Oct 18, 2019 at 4:52 PM William Ayd ***@***.***> wrote: did brew not have some kind of thing after installation to link sed to gnu-sed? I vaguely recall some post-install step to make that happen — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#17?email_source=notifications&email_token=AAKAOIQPKTHCXPGGYVIEVK3QPIVZFA5CNFSM4JCLTAFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBWEYRA#issuecomment-543968324>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKAOIVHSFRQKQYXETZPBCTQPIVZFANCNFSM4JCLTAFA> .

[jbrockmendel]

did brew not have some kind of thing after installation to link sed to gnu-sed?

That's plausible, not sure. Me screwing up is the kind of failure mode we should all be used to be now.

There was also an issue in wheels.sh the sed call to write BUILD_COMMIT=... into .travis.yml didnt do anything (with sed or gsed), which caused make wheels to fail for a while.