Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node exporter endpoint for Pigeon metrics #1083

Open
aditya-manit opened this issue Feb 8, 2024 · 1 comment
Open

Node exporter endpoint for Pigeon metrics #1083

aditya-manit opened this issue Feb 8, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@aditya-manit
Copy link

Feature Request

Summary

I would like to request the implementation of a Prometheus-style node exporter endpoint for Pigeon metrics. This would enable us to monitor our nodes more effectively by leveraging Prometheus for data aggregation and alerting.

Detailed Explanation

Prometheus is a widely used monitoring tool that collects metrics from configured targets at given intervals, evaluates rule expressions, displays results, and can trigger alerts if some conditions are observed to be true. Integrating Prometheus-style metrics collection into Pigeon would greatly enhance our ability to monitor node health, performance, and reliability in real-time.

Specific Metrics Needed

We can include pigeon metrics, similar to those provided by the palomad q metrix command for validators, formatted in a Prometheus-compatible way:

  • val_address: The validator's address
  • success_rate: Rate of successful operations or transactions
  • execution_time: Time taken to execute operations or transactions
  • fee: Fees associated with transactions or operations
  • feature_set: A numerical representation of the available features or capabilities

An example of the current metric output in JSON format is provided below:

{
  "val_metrics": {
    "val_address": "palomavaloper1cs6trg6chgcw0t8dzjx9tup7emctxxtwk8lxqn",
    "uptime": "0.960000000000000000",
    "success_rate": "0.500000000000000000",
    "execution_time": "0",
    "fee": "0",
    "feature_set": "0.000000000000000000"
  }
}
@aditya-manit aditya-manit added the enhancement New feature or request label Feb 8, 2024
byte-bandit added a commit that referenced this issue Feb 8, 2024
# Related Github tickets

- #1083
- VolumeFi#1257

# Background

All custom modules have at least some HTTP API endpoints configured, but
none of them were enabled. This change makes sure all modules register
their endpoints accordingly. Make sure to set `api.enable` to `true` in
`~/.paloma/config/app.toml` by default the API is disabled.

# Testing completed

- [x] test coverage exists or has been added/updated
- [x] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
@taariq
Copy link
Contributor

taariq commented Feb 8, 2024

Fixed with #1085. Please test it out @aditya-manit when you get a chance.

@taariq taariq closed this as completed Feb 8, 2024
@taariq taariq reopened this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants