fix async_generator error by making the app fixture async #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are yielding the app fixture but not passing it as an argument which seems to break the second part of the documentation where we attempt to access the `test_client()` it gives an async_generator. ```bash AttributeError: 'async_generator' object has no attribute 'test_client' ```
john0isaac
changed the title
|
Does this depend on the pytest-asyncio mode you are using? As it works for me without this change here |
|
@pgjones I'm using the default values for everything. I will reproduce and get back to you with the detailed versions of everything in an isolated environment. This is my working setup here. Have you tested this recently? Maybe it changed in the latest versions but was working previously.. My change works on Python 3.10, 3.11, 3.12 but I will reproduce again and leave detailed comment with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app fixture is not created as an async fixture which results in breaking the second part of the documentation where we attempt to access the
test_client()it gives an async_generator.This PR fixes that to pass the tests
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.