Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid ResourceWarning in DataBody.__aiter__ #302

Merged
merged 4 commits into from May 19, 2024
Merged

avoid ResourceWarning in DataBody.__aiter__ #302

merged 4 commits into from May 19, 2024

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Dec 18, 2023 •
edited

Avoid a ResourceWarning by avoiding an async generator

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@graingert graingert marked this pull request as ready for review December 18, 2023 12:37
@graingert
Copy link
Contributor Author

tests are tricky for this, as it only causes the warning on quart-trio

@pgjones pgjones merged commit 6a45284 into pallets:main May 19, 2024
11 checks passed
@pgjones
Copy link
Member

pgjones commented May 19, 2024

Thanks

@graingert graingert deleted the avoid-resource-warning-in-data-body-aiter branch May 19, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidism davidism Awaiting requested review from davidism

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResourceWarning from DataBody.__aiter__
3 participants
@graingert @pgjones @davidism