Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing for abort to accept Response object #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typing for abort to accept Response object #201

wants to merge 1 commit into from

Conversation

touilleMan
Copy link
Contributor

fixes #200

@touilleMan
Copy link
Contributor Author

see #202 for the CI failing :/

pgjones
pgjones reviewed Oct 25, 2022
View reviewed changes
src/quart/helpers.py
@@ -389,7 +389,7 @@ def _split_blueprint_path(name: str) -> List[str]:
return bps


def abort(code: int, *args: Any, **kwargs: Any) -> NoReturn: # type: ignore[misc]
def abort(code: int | Response, *args: Any, **kwargs: Any) -> NoReturn:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Werkzeug's aborter can accept a Quart Response. I think this part of the API is unhelpful - what use case do you have in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgjones pgjones pgjones left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

abort typing doesn't accept Response as a valid parameter
2 participants
@touilleMan @pgjones