New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional signal arguments #150

Open

pgjones opened this issue Jul 7, 2022 · 1 comment

Member

pgjones commented Jul 7, 2022

...why the websocket_sent/websocket_received signal don't provide the app object as parameter ?
On top of tath, given websocket is a stateful protocol, I would have expected to have websocket_started signal providing a kind of id websocket connection id that is again provided with subsequent websocket_sent/websocket_received/websocket_finished signals 🤔

From pgjones/quart-trio#1

Vivanov98 commented Sep 2, 2022

Both the current app and the current websocket connection are context-local globals. Is there another reason to add them as arguments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment