Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

no-implicit-dependencies doesn't support absolute paths beginning with @ #4103

Closed
jeznag opened this issue Aug 7, 2018 · 3 comments
Closed

Comments

@jeznag
Copy link

jeznag commented Aug 7, 2018

Bug Report

function getPackageName(name: string): string {

means that paths beginning with @ are not properly considered in the whitelist for no-implicit-dependencies. Using @ at start of path is relatively common.

  • TSLint version: 5.11.0
  • TypeScript version: 2.9.2
  • Running TSLint via: (pick one) CLI

TypeScript code being linted

import DataJunction from '@App/DataJunction';
import { Provider as I18nProvider } from '@App/I18nContext';
import RequestData from '@App/RequestData';

with tslint.json configuration:

{
    "no-implicit-dependencies": [false, "dev", ["@App", "@App/Shared"]],
}

Actual behavior

linter throws error about implicit dependencies

Expected behavior

linter should pass

@eps1lon
Copy link
Contributor

eps1lon commented Aug 9, 2018

Sounds like a duplicate of #4083

@jeznag
Copy link
Author

jeznag commented Aug 9, 2018

@eps1lon it's not. #4083 is a duplicate of #3483 This is a separate issue.

@johnwiseheart
Copy link
Contributor

Duplicate of #4058

@johnwiseheart johnwiseheart marked this as a duplicate of #4058 Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants