Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to lock database when closing browser #146

Open
mrjohnson22 opened this issue Mar 10, 2024 · 1 comment
Open

Option to lock database when closing browser #146

mrjohnson22 opened this issue Mar 10, 2024 · 1 comment

Comments

@mrjohnson22
Copy link

With auto-lock disabled, the legacy PfP extension still asked for the master password the next time the browser was opened. With this version, at least on Firefox (either Linux or Windows), disabling auto-lock & unlocking once has passwords remain accessible on the next browser session without being prompted for a master password. It may also be the case that this happens when auto-lock is enabled, but the browser is closed while the database is unlocked & the lock timeout has not passed.

It's arguably a feature to leave the database permanently unlocked, so a compromise is to have an option to auto-lock the database when the browser is closed. That way, it's possible to leave it unlocked for an entire Firefox session & to not have to remember to manually lock it if it should be locked on the next browser session.

Possibly related to #142

@palant
Copy link
Owner

palant commented Mar 14, 2024

This shouldn’t be an option, this should be the default behavior. Unfortunately, it’s the browser which restores the state after a restart. I’m not sure how one would prevent it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants