Issue 96

[jphager2]

This is a work in progress. (also see the TODOs)

This provides the api for managing forms.

view.form(:user).create(User.new) do |form, user|
  # ... extra manipulation of the form view
end

view.form(:user).update(User.find(1))

View#form is simply a alias for View#scope and #create and #update (for both View and ViewCollection) uses bind to preform the normal data binding, then adds the specific form data, then passes the view to the block passed by the caller.

[bryanp]

Thanks for taking this on! Couple thoughts here:

1. The form method should be defined on ViewContext. This will give it access to the request parameters. When you call view from a route, you're really creating a ViewContext instance that contains the view and the request context (see here).

2. I think we should create a Form object with the value from scope. This would give us a place to define create and update without polluting View with form-specific methods. Since theForm instance would be created from ViewContext, we would create it with the request context, giving it access to params (and anything else it might need).

[jphager2]

Thanks for the feedback. Could you take a look at the spec to see if they are okay? Do we need more than these for now?

[bryanp]

Let's rename form_view to view. It's already scoped within the form, so it seems redundant.

[bryanp]

Ah, I love this. But I think you could write your example like this:

data = { id: 1, name: 'a', images: [{ id: 1, name: 'b' }, { id: 2, name: 'c' }] }
view.form(:album).update(data) |view|
  view.scope(:image).apply(data[:images]) do |fields, image|
    fields.prop(:name).attrs.name = "album[images][#{image[:id]}[name]"
  end
end

[jphager2]

Ok so just to be on the same page (since in the last iteration, I removed bind_form_action), should the Form action methods take a block in the same way as View#bind? So that if the block has an arity of 1 then it is evaluated with instance_exec in the view's context, otherwise the method yields the view and the current data to the block? Or are we going to do something different for Form?

Because looking at your updated example, it seems that you want the method to simply yield the view to the block.

[bryanp]

That's a good point. For consistency, we should instance_exec when arity == 1. And that should happen in context of the Form's view, not the Form instance. Make sense?

[bryanp]

Looks good to me! @jphager2: anything else you'd like to do or ask before I merge?

[jphager2]

I'm happy with it.

[bryanp]

Thanks :)