This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
Convert to SCSS Modules #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typography Update
Would love any feedback/suggestions as I keep trucking along. |
|
Adjusted the figure option to maintain
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description⚠️ WIP - Do not merge! ⚠️
Convert from a single
SCSSfile toSCSSmodules to allow better customization and updates.Changes
❌ Removed ❌
Templates (HTML)
partials/site-sidebar.html❌ Removed (Merged intopartials/site-footer.html)CSS
nav#site-nav❌ Removed$breakpointsand@include break($breakpoint)❌ Removed-upsuffix (ex.$desktop-up->$desktop)#site-intro headercontainer ❌ Removed#site-intro maincontainer ❌ Removed#site-intro footercontainer ❌ Removed.article-terms-link❌ Removed#recent-posts headercontainer ❌ Removed#recent-posts footercontainer ❌ Removed#categories headercontainer ❌ Removed#categories footercontainer ❌ RemovedTemplates (HTML)
partials/socnet-icon.htmlpartials/social-icons.htmlCSS
.nav .link.nav-linkmenu#site-nav-menu.flyout-menu.menunav#site-nav-menu.flyout-menu.share-toggle..search-toggle,.nav-toggle.toggle+.share-button,.search-button, or.nav-button#search(#search-input.active,#search-results.active).activeto#searchand ❌ Removed from#search-inputand#search-results.socnet-icons.social-icons.title.post-description.meta.post-meta.content.post-contentsection#site-sidebarfooter#site-footer#mini-bio#aboutfooter#site-footersection#copyrightMotivation and Context
[Why is this change required? What problem does it solve?]
Progress towards #252
Closes #250
Progress towards #244
Progress towards #218
Closes #164
Closes #178
Screenshots (if appropriate):
N/A
Checklist:
theme.toml, as applicable.