Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow overwriting props #201

Open
gylxan opened this issue Jan 9, 2024 · 2 comments · May be fixed by #202
Open

feat: allow overwriting props #201

gylxan opened this issue Jan 9, 2024 · 2 comments · May be fixed by #202

Comments

@gylxan
Copy link

gylxan commented Jan 9, 2024 •
edited

There are many cases where it makes sense to override the props of the components.

Examples:

  • aria-label of e.g. CommandLoading and CommandList to support multi language
  • aria-expanded of CommandInput, which is always true currently, but should only be true, when the input has focus or after typing, when the list is shown
  • type of CommandInput to let users only insert numbers for instance

There is already a PR for it #117, but I created a new one #202

Here is a code sandbox, where we can see the problem

Maybe we can realize it?
@MatchuPitchu
Copy link

Would be very useful.

@gylxan gylxan linked a pull request Jan 9, 2024 that will close this issue
Open
@albertAS61
Copy link

Glad to see @gylxan that someone also pick up the topic with overwriting props. For me the most important part is with type of command input. Topic also arise in #175 and for me the crucial part with changing type is that on mobile I can force browser to use specific type of keyboard :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow overriding props of components gylxan/cmdk
3 participants
@gylxan @MatchuPitchu @albertAS61