Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Available IP Reservations sends BODY in GET request #364

Open
displague opened this issue Apr 26, 2023 · 0 comments
Open

Getting Available IP Reservations sends BODY in GET request #364

displague opened this issue Apr 26, 2023 · 0 comments

Comments

@displague
Copy link
Member

displague commented Apr 26, 2023

packngo/ip.go

Line 386 in f12198a

resp, err := i.client.DoRequest("GET", apiPathQuery, r, ar)

The intention is for the cidr request filtering to be submitted as a query parameter. The request may be rejected as an invalid/suspicious request as coded today.

Succinctly, r should be translated to query params and the request body should be nil as it is everywhere else:

packngo $ git grep -n DoRequest.*GET.*| grep -v nil
ip.go:386:	resp, err := i.client.DoRequest("GET", apiPathQuery, r, ar)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant