Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base URL alternative should be configurable via the environment #322

Open
displague opened this issue Feb 22, 2022 · 1 comment · May be fixed by #351
Open

Base URL alternative should be configurable via the environment #322

displague opened this issue Feb 22, 2022 · 1 comment · May be fixed by #351
Milestone

Comments

@displague
Copy link
Member

Alternate base URLs, such as the legacy https://api.packet.net, may be useful during testing. PACKNGO_API_BASE_URL could be used to configure such a change.

No other mechanism currently exists.
If packngo supported this feature, downstream tools may need to be adapted to inherit this value, alternatively, these tools could offer their own way to provide the base URL.

@displague
Copy link
Member Author

This could also be used with tools like Prism https://github.com/stoplightio/prism#validation-proxy. When applied against the Terraform E2E tests, for example, this could be used to identify if the TF implementation and packngo (or metal-go) are true to the API spec (and that the API is true to the API spec).

@displague displague linked a pull request Feb 22, 2023 that will close this issue
@displague displague added this to the v0.30 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant