Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line inconsistencies & silent drops #306

Open
smangham opened this issue Jul 23, 2020 · 1 comment
Open

Command line inconsistencies & silent drops #306

smangham opened this issue Jul 23, 2020 · 1 comment

Comments

@smangham
Copy link
Contributor

When using the Grid configuration scripts, Grid uses the format --argument=value. However, when running Grid from the command line, it expects dimensions & MPI splits to be passed as --argument value. This inconsistency isn't really a major problem, except that if you do accidentally provide them to Grid as --argument=value they're silently ignored and the default values used.

This is just a bit of a pain. It would be better if either

  • --argument=value was interpreted as --argument value

Or

  • Invalid arguments were rejected and terminated the run
@paboyle
Copy link
Owner

paboyle commented Mar 4, 2021

Can't terminate on invalid arguments as the command line may still be parsed by the user application.
This is a common convention in libraries like MPI where argc and argv are passed to library, and they snarf and remove args.
However, I can think about extra parsing for "=", though of course the work in enhancing the parsing is significantly greater than the work on a user to not type in "=".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants