Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix axe level translation #685

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

[WIP] Fix axe level translation #685

wants to merge 27 commits into from

Conversation

danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Nov 17, 2023 •
edited

Full description pending.

Thoughts

  • Semver: I've pencilled this in for 8.x, but would this fix be considered to require a major bump? So far I've seen a couple of workarounds that ignore rules that are emitting these false positives but I suppose people could be forming a contract with Pa11y's current output. On the other hand it isn't behaviour we intended - it's a bug.
  • Fix the potentially objective bugs reported
  • Confirm current axe level list
  • Consider more lenient translation of unknown levels

@danyalaytekin danyalaytekin added this to the 7.0.1 milestone Nov 17, 2023
@danyalaytekin danyalaytekin self-assigned this Nov 17, 2023
@danyalaytekin
Add npm start helper
e91c5ee
@danyalaytekin
Tidy up pa11y module
62cffc7
@danyalaytekin
Lint with ES2020
3962ca6
@danyalaytekin
Assemble runner bundle with map.join, and document StringifiedRunner
838a246
@danyalaytekin
Rename exports to less ambiguous exporter
a5c4b50
@danyalaytekin
Change strict check for file to error
e77c360
@danyalaytekin
Destructure response and run inside it (expand both patterns in fut…
10dd1bd 
…ure to improve clarity)
@danyalaytekin
Condense pa11y-cli helper
e69974f
@danyalaytekin
Rename aXe to axe
41b8122
@danyalaytekin
Use node ... in npm start
d21a68c
@danyalaytekin
Gather useful @typedefs from axe-core
e1670e5
@danyalaytekin
Improve runOnly's formatting
d0d56d7
@danyalaytekin
Remove effective noops processViolation and processIncomplete
8c919ec
@danyalaytekin
Add placeholder typedefs Pa11yRunner and Pa11yImpact
5519c8d
@danyalaytekin
Reorganise axe runner for clarity - remove overridden processors, des…
269f9dd 
…tructure/use types - avoid regression here
@danyalaytekin
Mention how axe runner is injected into browser
01f2948
@danyalaytekin
Remove smuggled logging
5955606
@danyalaytekin
Fix inaccuracy in description of standard
93e48e6
@danyalaytekin
Match help for --standard to behaviour
7c33925
@danyalaytekin
Use Pa11y's vocabulary (levels)
4b3ea1a
@danyalaytekin
Fix a couple of JSDoc Objects (→ object)
c7cfb0d
@danyalaytekin
Document type Pa11yConfiguration (placeholder, because currently be…
562810d 
…haves `as const`)
@danyalaytekin
Rename pa11yStandardToAxe → createAxeRunOnlyTags, consume documen…
115258f 
…tation for `AxeRunOnly`
@danyalaytekin
Document type Pa11yStandard and use
a234258
@danyalaytekin
Clarify signature for runPa11yWithOptions and tighten linter override
ad4854d
@danyalaytekin
Use documentation for Pa11yConfiguration
4d0e571
@danyalaytekin danyalaytekin mentioned this pull request Nov 28, 2023
Merged
@delucis delucis mentioned this pull request Feb 29, 2024
Merged
@danyalaytekin danyalaytekin modified the milestones: 7.0.1, future Mar 9, 2024
@danyalaytekin danyalaytekin added the status: work required Issues or PRs that are incomplete and require work label Mar 9, 2024
@danyalaytekin danyalaytekin modified the milestones: future, 8.x Mar 15, 2024
@danyalaytekin danyalaytekin mentioned this pull request Mar 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danyalaytekin danyalaytekin

Labels
status: work required Issues or PRs that are incomplete and require work
Projects
None yet
Milestone
8.x
1 participant
@danyalaytekin