Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignore url handling #536

Closed
wants to merge 5 commits into from
Closed

Fix ignore url handling #536

wants to merge 5 commits into from

Conversation

wesrice
Copy link

@wesrice wesrice commented Oct 29, 2020

Closes #535

@wesrice wesrice changed the base branch from master to release-5.3.0 October 29, 2020 13:20
@wesrice wesrice changed the base branch from release-5.3.0 to master October 29, 2020 15:10
joeyciechanowicz
joeyciechanowicz approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@joeyciechanowicz joeyciechanowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, and some lovely tests. Just needs the merge conflicts fixed, which seems not too bad, and we're good to go 🚀

@danyalaytekin danyalaytekin deleted the branch pa11y:master October 9, 2023 12:26
@danyalaytekin
Copy link
Member

Hey @wesrice, thanks for this contribution. pa11y:master has actually been renamed to pa11y:main, rather than deleted. Thanks for the jumpscare, GitHub.

It looks like the repo forwarding from fork to origin doesn't work (which goes into my collection as the second example of it not working, alongside a mention of master in a GitHub Actions workflow).

I haven't read the content of your PR yet but @joeyciechanowicz seemed excited about it so if it remains relevant please do recreate it, targetting main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyciechanowicz joeyciechanowicz joeyciechanowicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When setting a default of ignoreUrl: true, the pa11y() function shouldn't require a url parameter
3 participants
@wesrice @danyalaytekin @joeyciechanowicz