Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible comma misuse warning in shuffle2x2.h #146

Open
peabody-korg opened this issue Jul 2, 2020 · 1 comment
Open

possible comma misuse warning in shuffle2x2.h #146

peabody-korg opened this issue Jul 2, 2020 · 1 comment

Comments

@peabody-korg
Copy link
Contributor

xcode SSE build, dev branch at dcc04d1

Possible misuse of comma operator here:

line 277:
float32<4> fa, fb; fa = a, fb = b;

line 282:
float32<4> fa, fb; fa = a, fb = b;

guessing both of these should probably be semicolons instead.

@abique
Copy link
Contributor

abique commented Jul 16, 2020

I think so too.
This coding style is dodgy ;-)

Maybe you can provide a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants