New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a cell view #25

Open

reder2000 opened this issue Apr 21, 2022 · 0 comments

Contributor

reder2000 commented Apr 21, 2022

Rather than building a full string, returning a string view may be more efficient in some cases (suppose one wants to drop a column).
Something like:

class Cell { [...]
std::string_view read_view() const {
return std::string_view(buffer_ + start_, end_ - start_);
}

[...]
};

Even for conversion, it's probably enough.

reder2000 mentioned this issue

row size && string_view of cell #30

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment