Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Info for custom executors hidden for verbose runs in 1.2.0.beta2 #699

Open
miklosbagi opened this issue Jul 11, 2023 · 1 comment
Open
Labels
Milestone

Comments

@miklosbagi
Copy link
Contributor

miklosbagi commented Jul 11, 2023

Howdy,

I'm going through upgrading our tests to latest venom, and noticed that info is now disregarded for user defined custom executors.

Example with venom 1.1.0:

 		• exec PASS
 		• custom_executor PASS
 		• sql PASS
	  	  [info] Generating a UUID
	  	  [info]   [venom-custom_executor] Executing custom_executor request to localhost:9999 
	  	  [info] Fetching SQL data

Example with venom 1.2.0.beta2:

 		• exec PASS
 		• custom_executor PASS
 		• sql PASS
	  	  [info] Generating a UUID
	  	  [info] Fetching SQL data

Notice that the custom executor is missing (the one indented in first).
Example for the custom executor code in lib/:

executor: custom_executor
input:
  tag: "  [venom-custom_executor]"

steps:
- script: echo
  info: "{{.input.tag}}  Executing custom_executor request to localhost:9999"
  assertions:
  - result.code ShouldEqual 0

This has been introduced by this change in #617, where the intention is to hide this from non-verbose runs.

Can we have that back on, please? :)

Thanks,
mb

@miklosbagi miklosbagi changed the title Custom executors info not available in 1.2.0.beta2 [bug] Custom executors info not available in 1.2.0.beta2 Jul 11, 2023
@miklosbagi miklosbagi changed the title [bug] Custom executors info not available in 1.2.0.beta2 [bug] Info for custom executors hidden for verbose runs in 1.2.0.beta1 and above Jul 11, 2023
@miklosbagi miklosbagi changed the title [bug] Info for custom executors hidden for verbose runs in 1.2.0.beta1 and above [bug] Info for custom executors hidden for verbose runs in 1.2.0.beta2 and above Jul 11, 2023
@miklosbagi miklosbagi changed the title [bug] Info for custom executors hidden for verbose runs in 1.2.0.beta2 and above [bug] Info for custom executors hidden for verbose runs in 1.2.0.beta2 Jul 11, 2023
@yesnault yesnault added the bug label Jul 26, 2023
@yesnault yesnault added this to the 1.2.0 milestone Jul 26, 2023
@ivan-velasco
Copy link
Contributor

@yesnault any update when we will get this into a beta release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants