Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using a global logger? #692

Open
skateinmars opened this issue Jun 30, 2023 · 0 comments
Open

Stop using a global logger? #692

skateinmars opened this issue Jun 30, 2023 · 0 comments

Comments

@skateinmars
Copy link

Hello,

I have been trying to integrate venom as a library in our tooling, but I have come across issues when trying to run scenarios in parallel

Unfortunately, when calling InitLogger() on a venom.Venom struct, the global logrus logger also gets reset and replaced (with the log output file also being overridden).
The obvious solution seems to be adding a logrus field to the Venom struct

Obviously this global logger is used everywhere in code and executors (via the global funcs), so replacing this usage may be time consuming. So the question is, do you believe this work is worth doing to improve the usage of venom as a library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant