Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc innacuracy #429

Open
rbeuque74 opened this issue Apr 13, 2023 · 0 comments
Open

Doc innacuracy #429

rbeuque74 opened this issue Apr 13, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@rbeuque74
Copy link
Member

Describe the bug
Documentation here: https://github.com/ovh/utask#steps indicates

Several conditions can be specified, the first one to evaluate as true is applied. A condition is composed of:

It's actually not true.
All the conditions are evaluated, regarding if one prior was true

We actually have unit test that validates this behavior

utask/engine/engine_test.go

Line 465 in 93929c6

assert.Equal(t, step.StateToRetry, res.Steps["stepOne"].State)

https://github.com/ovh/utask/blob/master/engine/templates_tests/stepCondition.yaml#L13-L27

We need to patch the documentation
@rbeuque74 rbeuque74 added the bug Something isn't working label Apr 13, 2023
@rbeuque74 rbeuque74 mentioned this issue Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rbeuque74