-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webauthn): delete doesn't require challenge and use enroll wrapper #10084
Conversation
f96c55d
to
ba2e1ff
Compare
ba2e1ff
to
da94133
Compare
da94133
to
405ae24
Compare
US: 'https://auth.us.ovhcloud.com/webauthn/enroll', | ||
}; | ||
|
||
export default WEBAUTHN_URL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Export an object, so that we can add more properties in future.
export default WEBAUTHN_URL; | |
export default { | |
WEBAUTHN_URL, | |
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
$scope.u2f.isLoading = false; | ||
}); | ||
}; | ||
$scope.init = () => {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Empty function can be removed.
Also don't forget to remove it from Line number 10 on packages/manager/apps/dedicated/client/app/account/user/security/u2f/delete/user-security-u2f-delete.html
$scope.init = () => {}; | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
405ae24
to
5c7c9cd
Compare
Signed-off-by: Thomas SOËTE <thomas.soete@ovhcloud.com>
5c7c9cd
to
6a34dbc
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hi, i just want to let you know that iCloud is showing twice under the same name at the login prompt, and a single time at the dashboard/security panel view, and as you now have to select the right key at the login prompt, it makes unpredictable iCloud selection (iCloud 1 : Browser prompt key or QR code, iCloud 2 : Browser prompt in device passkey), device name is not enough, it misses like parenthesis next to with the workflow involved or better an icon to show us), at least internal auth / external auth |
@gegtor weird, actually both 001 and 002 on my screenshot are Yubikey 5C NFC, You are allowed to rename your key on the dashboard / security ! Try to do that :) |
It doesn't show up in dashboard but does while logging in |
master
/release/**
/develop
Description
Fix security keys
Related