Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure auth fails for organistion guests #6842

Open
david-loe opened this issue Apr 24, 2024 · 6 comments
Open

Azure auth fails for organistion guests #6842

david-loe opened this issue Apr 24, 2024 · 6 comments
Labels
bug more information needed This issue will be automatically closed unless more details are provided self-hosted Issues related to self-hosting the code

Comments

@david-loe
Copy link

Login with an guest account fails.
Guest e.g. from MS Teams guests (https://learn.microsoft.com/en-us/microsoftteams/guest-access)

To Reproduce

  1. Login with a MS guest account

Expected behavior
Login with a guest account of an organisation should be possible.

Outline (please complete the following information):

  • Install: self hosted
  • Version: 0.75.2

Desktop (please complete the following information):

  • OS: macOS & Win 10
  • Browser: safari & firefox
  • Version: latest
@david-loe david-loe added the bug label Apr 24, 2024
Copy link

linear bot commented Apr 24, 2024

@tommoor tommoor added more information needed This issue will be automatically closed unless more details are provided self-hosted Issues related to self-hosting the code labels Apr 24, 2024
@tommoor
Copy link
Member

tommoor commented Apr 24, 2024

Hi @david-loe – we'll need more information in order to debug this, what errors are you seeing on the client and on the server? It's quite likely this is a restriction on Microsoft's side.

@david-loe
Copy link
Author

Hi @tommoor, thanks for your fast response!
There are no errors thrown, none on client side and none on server side (also LOG_LEVEL=debug did not reveal anything..)

After successfuly logging in at MS, I'm immediately redirected to the MS login page to login again.

With my self build web apps using passportjs (OAuth 2.0) guest login works (the returned profile has than only a displayName, givenName and familyName are null). And I integrated them the same way as outline on azure side. So I don't think it's on MS side as MS also doesn't throw any login errors.

@david-loe
Copy link
Author

image
This is how it looks on client side.
I successfully logged in to MS, and than no redirect to outline happens.

Copy link
Member

tommoor commented Apr 25, 2024

Could you check "Preserve log" in the developer tools and then do the end-to-end auth, we should see all the network requests including redirects on Outline's side

@david-loe
Copy link
Author

I just realized that my filters were set to XHR only.. so here is the network history again with more response types
image

And here the logs:
image

I didn't find any hint in the logs, maybe you have to try this out on your end and debug on your own 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug more information needed This issue will be automatically closed unless more details are provided self-hosted Issues related to self-hosting the code
Projects
None yet
Development

No branches or pull requests

2 participants