Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use emoji for collection icons #6475

Open
tommoor opened this issue Feb 2, 2024 · 6 comments
Open

Add option to use emoji for collection icons #6475

tommoor opened this issue Feb 2, 2024 · 6 comments
Labels
enhancement It would be nice if…

Comments

@tommoor
Copy link
Member

tommoor commented Feb 2, 2024

Related #6469 and #2356

Should be relatively straight forward, all the pieces exist.

@tommoor tommoor added the enhancement It would be nice if… label Feb 2, 2024
Copy link

linear bot commented Feb 2, 2024

@hmacr
Copy link
Contributor

hmacr commented Feb 26, 2024

Couple of approaches to solve this.

  1. Re-use the icon column and store the emoji. When displaying the collection info, check the collection-icons; otherwise fallback to emoji.
  2. Create a new column emoji. At any point, either icon (or) emoji is set for a collection.

I recommend #2 as it gives a cleaner separation between built-in icons and emojis.
@tommoor Your thoughts?

@tommoor
Copy link
Member Author

tommoor commented Feb 28, 2024

I think actually (1) is preferable, using the same column. It is easy to differentiate between an emoji and an icon, there is also a world where custom icons can be uploaded in the future and I wouldn't want to introduce another third column for that so I think it makes sense to keep it centralized.

In the medium term can probably rename the column on document from emoji -> icon to match and use the same schema.

@tommoor
Copy link
Member Author

tommoor commented Mar 12, 2024

@hmacr still interested in taking this or shall we pass it along?

@hmacr
Copy link
Contributor

hmacr commented Mar 13, 2024

@tommoor Oh yes definitely! I have been out for 2 weeks on personal time off.

I'm starting on #6215, and would take this one after that; so, in a day or two hopefully.
If customers are waiting for this feature, I can take it first; or pass it along too :)

Copy link
Member Author

tommoor commented Mar 13, 2024

Upto you, all contributions appreciated equally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement It would be nice if…
Projects
None yet
Development

No branches or pull requests

2 participants