fix: Limit ws payload size

outline · Aug 16, 2022 · ed8176c · ed8176c
1 parent cfa7ecd
commit ed8176c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/app/scenes/Document/components/MultiplayerEditor.tsx b/app/scenes/Document/components/MultiplayerEditor.tsx
@@ -139,6 +139,9 @@ function MultiplayerEditor({ onSynced, ...props }: Props, ref: any) {
     });
 
     if (debug) {
+      provider.on("close", (ev: MessageEvent) =>
+        Logger.debug("collaboration", "close", ev)
+      );
       provider.on("message", (ev: MessageEvent) =>
         Logger.debug("collaboration", "incoming", {
           message: ev.message,

diff --git a/server/services/collaboration.ts b/server/services/collaboration.ts
@@ -4,6 +4,7 @@ import url from "url";
 import { Server } from "@hocuspocus/server";
 import Koa from "koa";
 import WebSocket from "ws";
+import { DocumentValidation } from "@shared/validations";
 import Logger from "@server/logging/Logger";
 import AuthenticationExtension from "../collaboration/AuthenticationExtension";
 import LoggerExtension from "../collaboration/LoggerExtension";
@@ -18,6 +19,7 @@ export default function init(
   const path = "/collaboration";
   const wss = new WebSocket.Server({
     noServer: true,
+    maxPayload: DocumentValidation.maxStateLength,
   });
 
   const hocuspocus = Server.configure({

diff --git a/shared/validations.ts b/shared/validations.ts
@@ -32,7 +32,7 @@ export const DocumentValidation = {
   maxTitleLength: 100,
 
   /** The maximum size of the collaborative document state */
-  maxStateLength: 1000000,
+  maxStateLength: 1500 * 1024,
 };
 
 export const PinValidation = {