Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When there is no font-awesome icon? #165

Open
metasean opened this issue Apr 14, 2016 · 2 comments
Open

When there is no font-awesome icon? #165

metasean opened this issue Apr 14, 2016 · 2 comments

Comments

@metasean
Copy link

@oswaldoacauan - First, thank you for such an awesome design!
Maxime Gréau ported it over for HubPress, where I'm using it for my blog.

In trying to customize it, I ran into two problems.

The first was what to do when there was no appropriate fa-icon. I solved this by using svgs. See http://metasean.github.io/blog/

Which leads to the current problem with positioning of non-font-awesome icons in the drawer. I've tried everything I can to get them properly positioned, but there is something I'm clearly missing! The only thing that was even remotely useful was giving them a class of "fa". From what I can tell, there are no margins, no borders, and no padding, when possible they are text-aligned left. Alas, the two svg icons –CodeWars and JSBin– are not properly aligned. Does anyone have any idea why these svgs aren't following the same CSS rules as the other fa-icons?

@metasean
Copy link
Author

For anyone else in a similar situation, I ended up adding a margin-left: -0.2em to my svgs, then massaging each one from there [my mods]. It's more of a hack than I like using, but it seems to properly position the svg.

If someone has a less hacky approach, I'd love to read about it!

@bagrounds
Copy link

@metasean - where did you get the codewars svg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants