Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit circle game objects are pooled too early #347

Open
Rian8337 opened this issue Apr 22, 2024 · 1 comment
Open

Hit circle game objects are pooled too early #347

Rian8337 opened this issue Apr 22, 2024 · 1 comment
Milestone

Comments

@Rian8337
Copy link
Member

Rian8337 commented Apr 22, 2024

As the title says. This causes its animation to not finish properly after judgement, and its state will remain until it is reused, as shown in the video below.

km_20240223_480p_60f_20240223_012518.mp4
@Rian8337 Rian8337 added this to the 1.7.3 milestone Apr 22, 2024
@Reco1I
Copy link
Contributor

Reco1I commented Apr 30, 2024

https://github.com/osudroid/osu-droid/blob/master/src%2Fru%2Fnsu%2Fccfit%2Fzuev%2Fosu%2Fgame%2FSpritePool.java#L33-L54

The issue is here exactly. The sprite gets reset before using it back, this is indeed caused by what the title says.

There's a thing with SpritePool, I personally believe that it's not necessary since hit objects are already pooled by GameObjectPool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants