-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade engine to OpenGL ES 2.0 #331
base: master
Are you sure you want to change the base?
Conversation
its still missing some files, like here utils/adt/io |
Thanks to point that, I don't know why that is missing since I downloaded the repository from there. |
Well this is a surprise. |
since i researched, it's advisable to utilize the AndEngineAnchorCenter instead of the Gles2 branch, as it represents the latest and greatest. May you can look if its right but my guess it is^^ |
Upgrade to And personally I don't think it is the "greatest" since it just only introduces an offset/origin system as difference from the previous. Both are using OpenGL ES 2.0. |
# Conflicts: # src/ru/nsu/ccfit/zuev/osu/game/GameScene.java
# Conflicts: # src/com/edlplan/osu/support/slider/SliderBody2D.java # src/com/edlplan/ui/fragment/FilterMenuFragment.kt # src/com/reco1l/legacy/ui/entity/BeatmapButton.kt # src/com/reco1l/legacy/ui/multiplayer/RoomScene.kt # src/ru/nsu/ccfit/zuev/osu/LibraryManager.java # src/ru/nsu/ccfit/zuev/osu/MainActivity.java # src/ru/nsu/ccfit/zuev/osu/MainScene.java # src/ru/nsu/ccfit/zuev/osu/async/SyncTaskManager.java # src/ru/nsu/ccfit/zuev/osu/game/FollowTrack.java # src/ru/nsu/ccfit/zuev/osu/game/GameEffect.java # src/ru/nsu/ccfit/zuev/osu/game/GameScene.java # src/ru/nsu/ccfit/zuev/osu/game/ModernSpinner.java # src/ru/nsu/ccfit/zuev/osu/game/Slider.java # src/ru/nsu/ccfit/zuev/osu/game/Spinner.java # src/ru/nsu/ccfit/zuev/osu/menu/MenuItemTrack.java # src/ru/nsu/ccfit/zuev/osu/menu/ModMenu.java # src/ru/nsu/ccfit/zuev/osu/menu/SongMenu.java # src/ru/nsu/ccfit/zuev/osu/menu/SplashScene.java # src/ru/nsu/ccfit/zuev/osu/scoring/ScoringScene.java
In this PR I replacing the old AndEngine module which was based on OpenGL ES 1.0 branch to the OpenGL ES 2.0 implementation of the same engine.
There's some modifications that were re-applied to the engine as well recovery of removed features.
Benefits of the upgrade:
The PR is currently on WIP, I'm working on port things to it. Consider this as a second attempt as the original upgrade was intended and tested with the old rimu! code base which had positive results.
Some notes about modifications made in the module besides the upgrade:
UPDATED 21/3
Things pending to be fixed in order to set this PR as ready:
Particles doesn't show with certain blending functions, this includes Kiai particles inMainScene
andCursorTrail
particles.Fixed with f8aeca5
Some score text sprites have wrong sizes between texturesFixed with 3ce12d7
When focusing the game from being in background sliders and video stops working, this may be due to the custom shaders those elements use.Fixed with 62e4f30
Support blending in the new particles system.Fixed with 1eb4d63
Slider body rendering is completly removed due to uncompatibility, we should consider introduce newer slider rendering.Fixed starting from cb177b8
Sometimes (happens weirdly) the VBO for texts produces an IOOBE, this require further investigation because it can be an engine bug.Fixed with 1918204
Sometimes approach circles appears with full opacity by small time before the circle shows.Fixed with 7effdd9 (needs further testing).
Classic spinner doesn't clip the metre sprite properly.Fixed with 28bf98e
Blinking loading icon at game start.Fixed with 93dca14
Video is not working.Fixed with ee9a6a8
For reviewers:
import
s refactors. At this point the project is now compilable and playable.