Fix wrong textures being displayed before in-game video plays on certain devices #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's up, just a suggestion: Calling the driver at every draw call to get the renderer information can be a little of bit unnecessary. This should be done once (I'd do at the first draw call of the texture) and work with that. |
You're right, I overlooked that. Thanks for the suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #318.
Upon research across 2 devices and 2 emulators, it seems that there is possibly a bug in Mali GPUs' drivers that causes the wrong texture to be displayed before the beatmap's video starts, if present. The texture displayed is consistent across multiple gameplays, differing only whether the scoreboard is shown or not. This behavior is not present in Snapdragon devices and Android emulators, thus leading to the suspicion that Mali drivers are at fault.