Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare-root: Avoid retries #3219

Open
cgwalters opened this issue Mar 20, 2024 · 1 comment
Open

prepare-root: Avoid retries #3219

cgwalters opened this issue Mar 20, 2024 · 1 comment
Labels
area/prepare-root Issue relates to ostree-prepare-root

Comments

@cgwalters
Copy link
Member

I've seen some failure cases where when ostree-prepare-root.service fails, it ends up getting retried (not totally sure how)...and what happens is we get:

error: Failed to create /run/ostree: File exists

And that combined with other noise makes the real error scroll off the TTY...

So...I think we need to dig in and try to;

  • Ensure our unit doesn't get rerun
  • Try to add cleanup/idempotence on failure so we can rerun (a good bit harder)
@cgwalters cgwalters added the area/prepare-root Issue relates to ostree-prepare-root label Mar 20, 2024
jlebon added a commit to jlebon/ostree that referenced this issue Mar 21, 2024
This is stronger than the default (`replace`) because it tells systemd
to *stop everything* and go to `emergency.target`. In other codebases,
this has definitely helped me with the problem of "systemd keeps going
even after a failure".

Likely addresses ostreedev#3219.

See also e.g. coreos/ignition-dracut@3d2e165.
@jlebon
Copy link
Member

jlebon commented Mar 21, 2024

#3220 should definitely help. Hard to tell if it fixes it completely unless you can get a reproducer for the specific issue you've hit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prepare-root Issue relates to ostree-prepare-root
Projects
None yet
Development

No branches or pull requests

2 participants