Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fsverity conditionally in post-deploy (remove ex-integrity.composefs) #3202

Open
cgwalters opened this issue Feb 26, 2024 · 0 comments
Labels
area/composefs Issues related to composefs difficulty/low Not extremely difficult reward/medium Fixing this will be notably useful

Comments

@cgwalters
Copy link
Member

See #3165 (comment)

Basically cae4ceb wants to get rid of ex-integrity.composefs. To complete that picture let's change the deployment operation to walk over the objects and match the fsverity enablement to the composefs configuration.

  • If composefs is maybe, then try to enable fsverity, but don't hard error if we can't
  • If composefs is yes, then enable fsverity, or error if we can't

This would all be a bit more elegant if we changed the deploy logic to walk the ostree commit in memory instead of doing a checkout and read the composefs config that way. Longer term we want to do something like that anyways because we can avoid creating the hardlink tree that way, which would make things even more efficient.

The other angle to take on this is moving the composefs config into commit/container metadata outside of the image. I'd really like to eventually get to a world where composefs is opt-out instead of opt-in too...but ostree so far has had a very conservative backcompat setup.

@cgwalters cgwalters added reward/medium Fixing this will be notably useful area/composefs Issues related to composefs difficulty/low Not extremely difficult labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/composefs Issues related to composefs difficulty/low Not extremely difficult reward/medium Fixing this will be notably useful
Projects
None yet
Development

No branches or pull requests

1 participant