Android Bootloader (aboot) entries generated in config even in non-aboot deployments

[ericcurtin]

Below is an example of a Boot Loader Specification (BLS) file. In an Android bootloader environments the "aboot " entry is used to determine where the Android Boot Image file is located, which is flashed to the correct boot partition on deploy, either boot_a or boot_b. The "abootcfg " entry defines the correct configuration file to be used with this image. This is important information in an Android Bootloader environment, this info logically belongs with the other related boot information, kernel, dtb, initrd, etc.

cat /boot/loader/entries/ostree-1-centos.conf
title CentOS AutoSD 9 (ostree:0)
version 1
options root=LABEL=root ro loglevel=4 efi=runtime libahci.ignore_sss=1 console=ttyAMA0 ostree=/ostree/boot.1/centos/d44712f9935f7c6f30064e81ab2366e996f0989a064e2ec22326609c4b15d927/0
linux /ostree/centos-d44712f9935f7c6f30064e81ab2366e996f0989a064e2ec22326609c4b15d927/vmlinuz-5.14.0-339.302.el9iv.aarch64
initrd /ostree/centos-d44712f9935f7c6f30064e81ab2366e996f0989a064e2ec22326609c4b15d927/initramfs-5.14.0-339.302.el9iv.aarch64.img
abootcfg /ostree/deploy/centos/deploy/63f447ed1e231c07285b7525bf39683b5bdd20c189fc972411c67c4f387ed8ad.0/usr/lib/ostree-boot/aboot.cfg
fdtdir /ostree/centos-d44712f9935f7c6f30064e81ab2366e996f0989a064e2ec22326609c4b15d927/dtb
aboot /ostree/centos-d44712f9935f7c6f30064e81ab2366e996f0989a064e2ec22326609c4b15d927/aboot-5.14.0-339.302.el9iv.aarch64.img

The "aboot " and "abootcfg " entries are also present on non-aboot environments, this isn't necessarily an issue, but it's irrelevant information in a non-aboot environment and suggests aboot functionality is configured in non-aboot environments, which it is not.

On completion of this fix, the "aboot " and "abootcfg " entries exist in a aboot environment but not in others like a UEFI + grub environment.

CentOS Automotive Stream distribution is a good place to test this particular issue, see:

https://sigs.centos.org/automotive/building/

on info on how to build CentOS Automotive Stream images.

To build an Android Bootloader environment to test on it's:

git clone https://gitlab.com/CentOS/automotive/sample-images.git
cd sample-images/osbuild-manifests
make cs9-abootqemu-minimal-ostree.aarch64.qcow2

To build an UEFI + grub environment to test on it's:

git clone https://gitlab.com/CentOS/automotive/sample-images.git
cd sample-images/osbuild-manifests
make cs9-qemu-minimal-ostree.aarch64.qcow2

On completion of this issue, the aboot vm has the entries but the UEFI + grub one does not. Maybe try one "rpm-ostree install some_package" and reboot, just to ensure one deploy works on both images.