Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badger storage | RunValueLogGC() is managed with a fatal error #145

Open
pricelessrabbit opened this issue Jan 27, 2024 · 1 comment
Open

Comments

@pricelessrabbit
Copy link
Contributor

Hi all :) trying out the last version of the v2 branch and i got this error. The real issue is that inside clover storage, it's managed with a Fatal error.

  case <-ticker.C:
  err := store.db.RunValueLogGC(GCDiscardRatio)
  if err != nil && errors.Is(err, badger.ErrNoRewrite) {
	  log.Fatalf("RunValueLogGC(): %s\n", err.Error())
  }
  }

So as a result, my application exits every 5 mins with no way to recover from errors.
Is there a way to fix it? should i opening a PR with to allow for a non-fatal error log?

I also add a comment to the original issue about it.

@ostafen
Copy link
Owner

ostafen commented Jan 28, 2024

Yes, open a PR, please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants