Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MOI 1 #106

Open
lassepe opened this issue Feb 23, 2022 · 6 comments
Open

Support for MOI 1 #106

lassepe opened this issue Feb 23, 2022 · 6 comments

Comments

@lassepe
Copy link

lassepe commented Feb 23, 2022

OSQP currently pins MOI to 0.10.3. A few days ago, MOI as reached 1.0. It would be great to support MOI 1.0 within OSQP and adjust the compat bounds accordingly.

@odow
Copy link
Contributor

odow commented Jun 28, 2022

Closed by #110

@imciner2
Copy link
Member

Was that all that had to be done to transition to MOI 1.0, or are there other parts that we don't implement that we still need to?

@odow
Copy link
Contributor

odow commented Jun 28, 2022

Yeah maybe leave this open. There's actually a bunch of issues when I look through the code.

These should all be implemented and fixed:

"test_attribute_SolverVersion",
# Expected test failures:
# MathOptInterface.jl issue #1431
"test_model_LowerBoundAlreadySet",
"test_model_UpperBoundAlreadySet",
# FIXME
# See https://github.com/jump-dev/MathOptInterface.jl/issues/1773
"test_infeasible_MAX_SENSE",
"test_infeasible_MAX_SENSE_offset",
"test_infeasible_MIN_SENSE",
"test_infeasible_MIN_SENSE_offset",
"test_infeasible_affine_MAX_SENSE",
"test_infeasible_affine_MAX_SENSE_offset",
"test_infeasible_affine_MIN_SENSE",
"test_infeasible_affine_MIN_SENSE_offset",
# FIXME
# See https://github.com/jump-dev/MathOptInterface.jl/issues/1759
"test_unbounded_MAX_SENSE",
"test_unbounded_MAX_SENSE_offset",
"test_unbounded_MIN_SENSE",
"test_unbounded_MIN_SENSE_offset",
# FIXME
"test_model_copy_to_UnsupportedAttribute",
# Segfault
"test_model_copy_to_UnsupportedConstraint",

Let me take a look through. I have some time, and it'd be good to fix up OSQP.jl properly for JuMP 1.0.

@imciner2
Copy link
Member

If you could hold off doing any major updates to OSQP.jl for a while that would be appreciated. We are working on rebasing it to work with the updated API and library components that will be in v1 of the C library (hopefully being released soon), and have started those modifications in the vb/develop1 branch on this repo. We are hoping to get everything to a point where we will be ready for v1 of the C library by the end of July, at which point we can merge the interface changes and release a v1 here as well.

@imciner2
Copy link
Member

Alternately, if you want to target the branch we are working on the 1.0 version on, feel free to make more changes. But we don't have the jll it refers to pushed anywhere right now.

@odow
Copy link
Contributor

odow commented Jun 29, 2022

If you could hold off doing any major updates to OSQP.jl for a while that would be appreciated.

Okay, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants