Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logout #38

Open
2 of 4 tasks
evajacobs opened this issue Jul 19, 2016 · 6 comments
Open
2 of 4 tasks

Logout #38

evajacobs opened this issue Jul 19, 2016 · 6 comments
Labels
Medium Priority

Comments

@evajacobs
Copy link

evajacobs commented Jul 19, 2016 •
edited by TjenWellens

QuickFix

  • frontend link GET/logout
  • backend logout backend + redirect IDP logout

Actual fix

  • frontend: POST /logout (ajax call)
  • backend: logout iDP then logout backend
@Laurensdc Laurensdc changed the title logout button There is no logout button Jul 19, 2016
@TjenWellens
Copy link

go to url /logout

@TjenWellens
Copy link

Backend needs to redirect to idp's logout link

@TjenWellens TjenWellens reopened this Jul 22, 2016
@Laurensdc
Copy link

image

@Laurensdc
Copy link

@brechtvdv

@TjenWellens
Copy link

Backend can do the whole logout process aparently:

http://stackoverflow.com/questions/25271072/logging-out-using-passport-saml-req-logout-or-strategy-logout-or-both

So only a /logout redirect is needed.

TjenWellens pushed a commit that referenced this issue Jul 27, 2016
Merge branch 'feature/logout-quick-fix' into develop #38
91a71e6 
* feature/logout-quick-fix:
  redirect to logout link
  frontend logout link instead of ajax call
@TjenWellens TjenWellens changed the title There is no logout button Logout Jul 27, 2016
@Laurensdc
Copy link

redirecting to /logout now but it's just a href, not a link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Medium Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TjenWellens @Laurensdc @evajacobs