Superfluid multi-node testing issue tracker

[mattverse]

This issue is to track and confirm things are happening the way they should. Issues mentioned within this issue are from mulit-node environment. (Note that I might simply lack understanding and noting these out)

Also, instructions to the same setup is running ./multinode-local-testnet.shon a blank node, and runnning the following commands for basic superfluid set-up

touch stake-uosmo.json
nano stake-uosmo.json 
`
{
	"weights": "5stake,5uosmo",
	"initial-deposit": "1000000stake,1000000uosmo",
	"swap-fee": "0.01",
	"exit-fee": "0.01",
	"future-governor": "168h"
}
`

# testing with validator1
# create pool
osmosisd tx gamm create-pool --pool-file=./stake-uosmo.json --from=validator1 --keyring-backend=test --chain-id=testing --yes --home=$HOME/.osmosisd/validator1

# test swap in pool created
osmosisd tx gamm swap-exact-amount-in 100000uosmo 50000 --swap-route-pool-ids=1 --swap-route-denoms=stake --from=validator1 --keyring-backend=test --chain-id=testing --yes --home=$HOME/.osmosisd/validator1
osmosisd query gamm pool 1
osmosisd query bank balances $(osmosisd keys show -a validator1 --keyring-backend=test --home=$HOME/.osmosisd/validator1) --home=$HOME/.osmosisd/validator1

# create a lock up with lockable duration 2 min 
osmosisd tx lockup lock-tokens 10000000000000000000gamm/pool/1 --duration=360h --from=validator1 --keyring-backend=test --chain-id=testing --broadcast-mode=block --yes --home=$HOME/.osmosisd/validator1
osmosisd query lockup lock-by-id 1 --home=$HOME/.osmosisd/validator1
osmosisd query staking validators --home=$HOME/.osmosisd/validator1

# submit a gov proposal to set superfluid asset, deposit and pass proposal
osmosisd tx gov submit-proposal set-superfluid-assets-proposal --title="set superfluid assets" --description="set superfluid assets description" --superfluid-assets="gamm/pool/1" --deposit=10000000uosmo --from=validator1 --chain-id=testing --keyring-backend=test --broadcast-mode=block --yes --home=$HOME/.osmosisd/validator1
osmosisd tx gov deposit 1 10000000stake --from=validator1 --keyring-backend=test --chain-id=testing --broadcast-mode=block --yes --home=$HOME/.osmosisd/validator1
osmosisd tx gov vote 1 yes --from=validator1 --keyring-backend=test --chain-id=testing --yes --home=$HOME/.osmosisd/validator1
osmosisd tx gov vote 1 yes --from=validator2 --keyring-backend=test --chain-id=testing --yes --home=$HOME/.osmosisd/validator2
# query if superfluid asset exists
osmosisd query superfluid asset-multiplier gamm/pool/1 --home=$HOME/.osmosisd/validator1
# query intermediary accounts, should not have any intermediary accounts yet
osmosisd query superfluid all-intermediary-accounts --home=$HOME/.osmosisd/validator1


# get any of the val addresses to use for superfluid staking
osmosisd query staking validators --home=$HOME/.osmosisd/validator1

# superfluid delegate
osmosisd tx superfluid delegate 1 osmovaloper1vh2sdnecklyw3ksxusy7e3hgrk73cw5xqh9gzm --from=validator1 --keyring-backend=test --chain-id=testing --yes --home=$HOME/.osmosisd/validator1

[mattverse]

Address returns from non-existent connected-intermediary-account

Without anyone superfluid staked, osmosisd query superfluid connected-intermediary-account **any_int** returns an address. From my understanding, test code indicates that it shouldn't return an address but rather an empty address.

Log

# we have gamm/pool/1 registered as superfluid asset
root@ubuntu-s-4vcpu-8gb-amd-sfo3-01:~/osmosis# osmosisd query superfluid all-superfluid-assets
assets:
- asset_type: SuperfluidAssetTypeLPShare
  denom: gamm/pool/1

# this shows that noone has superfluid-staked before
root@ubuntu-s-4vcpu-8gb-amd-sfo3-01:~/osmosis# osmosisd query superfluid all-intermediary-accounts
accounts: []
pagination: null

# the part I don't understand. Querying returns a result with a address
root@ubuntu-s-4vcpu-8gb-amd-sfo3-01:~/osmosis# osmosisd query superfluid connected-intermediary-account 1
account:
  address: osmo1uwcvgs5clswpfxhm7nyfjmaeysn6us0ydmdj3a
  denom: ""
  gauge_id: "0"
  val_addr: ""

# lock seven does not exist but still returns an address
root@ubuntu-s-4vcpu-8gb-amd-sfo3-01:~/osmosis# osmosisd query superfluid connected-intermediary-account 7 --home=$HOME/.osmosisd/validator1
account:
  address: osmo1uwcvgs5clswpfxhm7nyfjmaeysn6us0ydmdj3a
  denom: ""
  gauge_id: "0"
  val_addr: ""

[mattverse]

Superfluid delegation rewards not being moved to gauges nor being auto distributed to delegators

From my understanding, every epoch that's ending should be calling MoveSuperfluidDelegationRewardToGauges, which is supposed to withdraw delegation rewards and add them to gauges which then gets auto-distributed to the delegators every epoch. The problem situation is that I'm not getting the rewards automatically from suerfluid staking.

Noting some of the genesis configuration that's related to epoch and distribution: incentvies.params.distr_epcoh_identifier= min, mint.params.epoch_identifier = min, superfluid.params.refresh_epoch_identifier=min

Log:

# check balances
root@ubuntu-s-4vcpu-8gb-amd-sfo3-01:~/.osmosisd/validator1/config# osmosisd query bank balances $(osmosisd keys show -a validator1 --keyring-backend=test --home=$HOME/.osmosisd/validator1) --home=$HOME/.osmosisd/validator1
balances:
- amount: "4000000000"
  denom: stake
- amount: "3600000000"
  denom: uosmo
pagination:
  next_key: null
  total: "0"
 
# check time
root@ubuntu-s-4vcpu-8gb-amd-sfo3-01:~/.osmosisd/validator1/config# date
Tue Feb 15 23:40:53 UTC 2022
  
# more than a minute(epoch time) has passed
root@ubuntu-s-4vcpu-8gb-amd-sfo3-01:~/.osmosisd/validator1/config# date
Tue Feb 15 23:44:34 UTC 2022

# balances are still the same
root@ubuntu-s-4vcpu-8gb-amd-sfo3-01:~/.osmosisd/validator1/config# osmosisd query bank balances $(osmosisd keys show -a validator1 --keyring-backend=test --home=$HOME/.osmosisd/validator1) --home=$HOME/.osmosisd/validator1
balances:
- amount: "4000000000"
  denom: stake
- amount: "3600000000"
  denom: uosmo
pagination:
  next_key: null
  
# nothing in the gauges as well 
root@ubuntu-s-4vcpu-8gb-amd-sfo3-01:~/.osmosisd/validator1/config# osmosisd q incentives gauges
data:
- coins: []
  distribute_to:
    denom: gamm/pool/1
    duration: 120s
    lock_query_type: ByDuration
    timestamp: "0001-01-01T00:00:00Z"
  distributed_coins: []
  filled_epochs: "67"
  id: "1"
  is_perpetual: true
  num_epochs_paid_over: "1"
  start_time: "2022-02-15T22:35:48.077726119Z"
- coins: []
  distribute_to:
    denom: gamm/pool/1
    duration: 180s
    lock_query_type: ByDuration
    timestamp: "0001-01-01T00:00:00Z"
  distributed_coins: []
  filled_epochs: "0"
  id: "2"
  is_perpetual: true
  num_epochs_paid_over: "1"
  start_time: "2022-02-15T22:35:48.077726119Z"
- coins: []
  distribute_to:
    denom: gamm/pool/1
    duration: 240s
    lock_query_type: ByDuration
    timestamp: "0001-01-01T00:00:00Z"
  distributed_coins: []
  filled_epochs: "0"
  id: "3"
  is_perpetual: true
  num_epochs_paid_over: "1"
  start_time: "2022-02-15T22:35:48.077726119Z"
- coins: []
  distribute_to:
    denom: gamm/pool/1superbondingosmovaloper1783a9rwv89p9lt4tywm2rswu7lvc9zzgj8wl55
    duration: 120s
    lock_query_type: ByDuration
    timestamp: "0001-01-01T00:00:00Z"
  distributed_coins: []
  filled_epochs: "63"
  id: "4"
  is_perpetual: true
  num_epochs_paid_over: "1"
  start_time: "2022-02-15T22:40:26.400490447Z"

[mattverse]

Confirmed that this was happening, fix in: #894

[ValarDragon]

OH wait the rewards not getting into gauges I did not know. That is a problem I haven't looked into, ty!

[czarcas7ic]

I am now getting rewards automatically, the fix in #894 was likely the cause

[ValarDragon]

is there a way to 'retire' discussions since we've finished things for this one?

[mattverse]

yeah I was searching for it as well :(