Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Suggestions] Connectivity Check #395

Open
ylinzhi opened this issue Oct 19, 2020 · 3 comments
Open

[Fix Suggestions] Connectivity Check #395

ylinzhi opened this issue Oct 19, 2020 · 3 comments
Assignees

Comments

@ylinzhi
Copy link
Contributor

ylinzhi commented Oct 19, 2020

Which Atlas check is the fix suggestion related to?

Connectivity Check
Description: This check identifies nodes that should be connected to nearby nodes or edges
Script: https://github.com/osmlab/atlas-checks/blob/e36a240f37344c99a25b00eb42c8e1b77b228a88/src/main/java/org/openstreetmap/atlas/checks/validation/points/ConnectivityCheck.java

Describe more details of suggested fix(es)

Suggested Fix 1:

  • Type of fixing: Geometry fix

  • Operation: Modify

  • Suggested Action: connect the node to proper nearest node or edge

Is there any code enhancement needed if adding the fix suggestion component?

No

@sayas01 sayas01 added this to To do in Auto-fix Suggestions via automation Oct 19, 2020
@Bentleysb
Copy link
Collaborator

This will involve some complicated tag merging for the 2 nodes, but worth a shot.

@atiannicelli
Copy link
Collaborator

@sayas01 can you assign this to @vladlemberg please

@vladlemberg
Copy link
Collaborator

@ylinzhi, @sayas01, @Bentleysb, @atiannicelli

Hello everyone,
I went through cases from the latest daylight MR challenge. My opinion
its a bit risky to offer a AutoFix suggestion for that challenge. Some of the cases visually looks straightforward to connect but after manual investigation it turns out as incorrect mapping.
Some examples (bad data):
https://maproulette.org/challenge/17794/task/100038393
image

image

Complicated Cases:
Node should be disconnected from the Admin Boundary, then connect to navigable road.
https://maproulette.org/challenge/17794/task/100026727

Tertiary Road connected via unmaintained track road.
image
https://maproulette.org/challenge/17794/task/100016546

Any opinion, suggestion ? Should we AutoFix only super clean cases ? So far I don't have method to isolate those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants