Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that a search result is from TIGER data #2754

Open
simonpoole opened this issue Jun 20, 2022 · 3 comments
Open

Indicate that a search result is from TIGER data #2754

simonpoole opened this issue Jun 20, 2022 · 3 comments

Comments

@simonpoole
Copy link

Is your feature request related to a problem? Please describe.
For a "normal" user the difference between results from TIGER and OSM data are not clear and can be surprising. In particular clicking on the result will select and display the street without any further explanation.

See for example https://www.openstreetmap.org/search?query=16%20Slayton%20Road%20melrose%20Massachusetts.#map=19/42.45596/-71.04467

Describe the solution you'd like

An indication in the results display that this is not a "proper" result from OSM.

@lonvia
Copy link
Member

lonvia commented Sep 17, 2022

I think we use to return a 'T' type for Tiger house numbers in osm_type but changed that when going to spelled out OSM types. @mtmail do you happen to have a reference to the discussion back then? If I remember correctly the reasoning was that osm_type should not contain surprising values. And that still holds. Putting a new value in there is a sure way to break clients.

Possible solutions:

  1. Leave out osm_type completely to indicate a non-OSM source. This is already done with artificial postcodes, so clients must be able to handle that. We'd loose the parent information. osm.org uses it to go to the parent street when clicking on the result.
  2. Add an additional source field. This could be generalized to any external data and combined with Different licence and copyright infomation for different data providers #1699.

Note that none of this will resolve that the source is shown on osm.org. Additional changes would be needed over there no matter what we do.

@mtmail
Copy link
Collaborator

mtmail commented Sep 21, 2022

@mtmail do you happen to have a reference to the discussion back then?

That might have been via email. It came up when https://github.com/osm-search/nominatim-ui was developed because while the old PHP HTML templates were able to infer a place came from TIGER data via internal variables the JSON/XML templates where missing the information. It remained an unsolved issue.

@mtmail
Copy link
Collaborator

mtmail commented Apr 9, 2024

Original test case no longer works because OSM mappers have added OSM house numbers around the location. New test case from another nominatim-docker discussion

1724 9th Avenue North, Bessemer, AL 35020, United States
https://nominatim.openstreetmap.org/ui/search.html?q=1724+9th+Avenue+North%2C+Bessemer%2C+AL+35020%2C+United+States

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants