Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example data and response matrices are not installed #188

Open
vetlewi opened this issue Sep 28, 2021 · 1 comment · May be fixed by #203
Open

Example data and response matrices are not installed #188

vetlewi opened this issue Sep 28, 2021 · 1 comment · May be fixed by #203
Milestone

Comments

@vetlewi
Copy link
Collaborator

vetlewi commented Sep 28, 2021

When installing using the command

pip install .

ie. not using the -e option ompy will be installed to the site-packages folder and not linked to the source folder. This will not copy the example_data and OCL_response_functions folders.

To fix this one should add a MANIFEST.in file with the following lines:

recursive-include example-data *
recursive-include OCL_response_functions *

I will fix this. Add it as an issue to remind myself :)

@vetlewi
Copy link
Collaborator Author

vetlewi commented Oct 22, 2021

This turns out to be a little more complex than I initially thought. The OCL_response_functions and example-data directories might have to move into the ompy directory in order for them to be copied correctly. Will do some more research to determine what the best coarse of action is...

EDIT
Okey... After a few google searches I've came to the conclusion that it might make more sense to refactor the examples package to download the example files directly from e.g. GitHub to a temporary folder.
Similarly it might make sense to make a separate ompy-response package that will allow for easy loading of response matrices. Will close the PR #189 and keep this issue open.

@vetlewi vetlewi added this to the Version 2.0 milestone Oct 22, 2021
@vetlewi vetlewi linked a pull request Jan 17, 2023 that will close this issue
@vetlewi vetlewi linked a pull request Jan 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant