Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More than one event should be allowed in case of coordinated delete #719

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

More than one event should be allowed in case of coordinated delete #719

wants to merge 2 commits into from

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Apr 27, 2024

Fix #718

@laeubi laeubi mentioned this pull request Apr 27, 2024
Open
@stbischof
Copy link
Contributor

@laeubi please update also the spec.

chrisrueger
chrisrueger reviewed May 8, 2024
View reviewed changes
Copy link

@chrisrueger chrisrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments.

org.osgi.test.cases.cm/src/org/osgi/test/cases/cm/junit/CMCoordinationTestCase.java Outdated Show resolved Hide resolved
org.osgi.test.cases.cm/src/org/osgi/test/cases/cm/junit/CMCoordinationTestCase.java Outdated Show resolved Hide resolved
@laeubi
Require one event should be delivered in case of coordinated delete
0bc15be 
Fix osgi#718

Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi
Copy link
Contributor Author

laeubi commented May 9, 2024

I tried to address the comments and adjusted the spec here is the generated specification: osgi.cmpn-8.1.0.pdf

chrisrueger
chrisrueger reviewed May 9, 2024
View reviewed changes
Copy link

@chrisrueger chrisrueger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I like the clarifications in the testcase.
  • I suggested a small typo correction

I just comment (instead of approve) because I don't feel I am qualified enough to judge this, since I was late in the game. But it sounds reasonable and makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrueger chrisrueger chrisrueger left review comments

@stbischof stbischof Awaiting requested review from stbischof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@laeubi @stbischof @chrisrueger